Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL duplicated in the no_default_layout deprecation message #336

Open
ankostis opened this issue Nov 29, 2023 · 3 comments
Open

URL duplicated in the no_default_layout deprecation message #336

ankostis opened this issue Nov 29, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@ankostis
Copy link

When using the deprecated no_default_layout (replaced by raw_plotly_config), eg:

type: custom:plotly-graph
no_default_layout: true
...

... the warning message contains 2 links to the docs:
image

... but the 2nd link is the same as the 1st one, while it should point to #204 (i guess):

return `replaced with more general <a href="https://github.com/dbuezas/lovelace-plotly-graph-card#raw-plotly-config">raw-plotly-config</a> in v3.0.0. See <a href="https://github.com/dbuezas/lovelace-plotly-graph-card#no_default_layout">layout migration guide</a>.`;

@ankostis ankostis added the bug Something isn't working label Nov 29, 2023
@dbuezas
Copy link
Owner

dbuezas commented Nov 29, 2023

Thanks for the issue.
It's intentional, the deprecation guide is just to replace it with what is stated in the linked section of the readme:

image

Is there anything missing from that?

@ankostis
Copy link
Author

No, it's fine
(just surprised the msg has 2 links pointing to the same URL)

@dbuezas
Copy link
Owner

dbuezas commented Nov 29, 2023

Oh, I see. I'll remove one of them later then to avoid confusion. Keeping open for now

@dbuezas dbuezas reopened this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants