Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to fully disable VimMode when used with hs.hotkey.modal #89

Open
robhanlon22 opened this issue Jan 21, 2022 · 2 comments
Open

Unable to fully disable VimMode when used with hs.hotkey.modal #89

robhanlon22 opened this issue Jan 21, 2022 · 2 comments

Comments

@robhanlon22
Copy link

Hello! I recently installed VimMode.spoon for the first time, and I've noticed that it doesn't play very nicely with hs.hotkey.modal out of the box. This is fine; I've added calls to VimMode:disable() and VimMode:enable() to the entered and exited hooks for hs.hotkey.modal. However, after using some of my modal hotkeys, I've noticed that VimMode ends up enabled again before the exited hook is called. This is most obvious when using a key sequence, as I have j bound within the hotkey modal, and it stops functioning because the sequence eventtap has started intercepting key sequences, looking for jk. Thanks :)

@dbalatero
Copy link
Owner

Oh no! Adding the disable() and enable() calls in the entered/exited hooks sounds like a good strategy to me, and I'm surprised that's not keeping them out of each other's way.

Could you share your modal code with me maybe? I can try to reproduce this in a vacuum perhaps with your modal setup.

@robhanlon22
Copy link
Author

robhanlon22 commented Jan 22, 2022

disorganized config here! hammerspoon.zip Caution, it will unzip to a .hammerspoon directory which you might not be able to see. It's a fairly simple set of modal binds that are manually hooked together with some external functionality (WindowSigils, RefreshConfiguration, VimMode, and the overlay that I took from your HyperKey project and modified)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants