premature closing?

[mr-git]

We are trying to use this library and we observe very strange behaviour:

• handling of valid request takes about a second
• bot is hitting server rapidly with many requests within short intervals, like tens of requests per second
• CircuitBreaker (CB) is configured to open after 10 failures for a minute
• CircuitBreaker (CB) is Closed
• CB.protect(..) starts handling one of the calls, let's name it X
• next 10+ requests fail due to internal locking and opens CB
• CB rejects some requests as expected using fail-fast shortcut
• [after a second] X finishes successfully and [unexpectedly for me] closes CB!!! <=== BUG or FEATURE?
• bot's next call gets through CB as new and slow X+1
• more requests fail due to internal locking and CB opens
• [after a second] X+1 finishes and closes CB
• cycle repeats

Is this expected that on

circuit/core/src/main/scala/io/chrisdavenport/circuit/CircuitBreaker.scala

Line 729 in 4e1e68e

case Open(_,_) => (ClosedZero, onClosed.attempt.void)

there is no check for expiresAt? similar as on

circuit/core/src/main/scala/io/chrisdavenport/circuit/CircuitBreaker.scala

Line 761 in 4e1e68e

if (open.expiresAt >= now) onRejected >> F.raiseError(RejectedExecution(open))

[mr-git]

from: https://doc.akka.io/docs/akka/current/common/circuitbreaker.html, https://doc.akka.io/docs/akka/current/images/circuit-breaker-states.png

There should not be transition from Open to Closed without going through HalfOpen