Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace colors rendering package for better Windows support #680

Open
myishay opened this issue Jun 12, 2022 · 1 comment
Open

Replace colors rendering package for better Windows support #680

myishay opened this issue Jun 12, 2022 · 1 comment
Labels
enhancement New feature or request up for grabs Looking for a contributor to take this task
Projects

Comments

@myishay
Copy link
Contributor

myishay commented Jun 12, 2022

Is your feature request related to a problem? Please describe.
Colors printing in Windows are being printed with strange charactest like this for example:
Screen Shot 2022-06-12 at 12 02 18

Describe the solution you'd like
Currently we are using https://github.com/fatih/color for color rendering.
From a quick check I have made, using https://github.com/jwalton/gchalk would solve our problem on Windows machines.

Describe alternatives you've considered
Another option would be debugging why we see those weird characters, as they were not rendered in previous versions.

@myishay myishay added enhancement New feature or request WIP Working in progress (will be deployed soon) labels Jun 12, 2022
@myishay
Copy link
Contributor Author

myishay commented Jun 12, 2022

I found the reason why the color support in Windows had a regression and added a fix here: #681

I still think it would be better using gchalk since it will make the use of a special output when printing redundant

@myishay myishay added up for grabs Looking for a contributor to take this task and removed WIP Working in progress (will be deployed soon) labels Jun 12, 2022
@github-actions github-actions bot added this to To Do in Datree Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request up for grabs Looking for a contributor to take this task
Projects
Datree
To Do
Development

No branches or pull requests

1 participant