Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LocalConfig package #439

Open
noaabarki opened this issue Feb 24, 2022 · 0 comments
Open

Refactor LocalConfig package #439

noaabarki opened this issue Feb 24, 2022 · 0 comments
Labels
enhancement New feature or request up for grabs Looking for a contributor to take this task
Projects

Comments

@noaabarki
Copy link
Contributor

Describe the solution you'd like
Cleanup:

  1. Delete LocalConfig(empty struct). Instead, export GetLocalConfiguration function. Add comments to this function.
  2. Remove getConfigName and getConfigType. Use const instead.
  3. Add setter and getter for token key in the local configuration.
  4. Cover these updates with testing. Use pkg/extractor or pkg/httpClinet as reference.

Requirements
Golang basic level.

@noaabarki noaabarki added enhancement New feature or request up for grabs Looking for a contributor to take this task labels Feb 24, 2022
@github-actions github-actions bot added this to To Do in Datree Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request up for grabs Looking for a contributor to take this task
Projects
Datree
To Do
Development

No branches or pull requests

1 participant