Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor evaluation.PrintResults signature #438

Open
noaabarki opened this issue Feb 24, 2022 · 0 comments
Open

Refactor evaluation.PrintResults signature #438

noaabarki opened this issue Feb 24, 2022 · 0 comments
Labels
enhancement New feature or request up for grabs Looking for a contributor to take this task
Projects

Comments

@noaabarki
Copy link
Contributor

Describe the solution you'd like

Location: bl/evaluation/printer:

func PrintResults(results ResultType, invalidYamlFiles []*validation.InvalidYamlFile, invalidK8sFiles []*validation.InvalidK8sFile, 
									evaluationSummary printer.EvaluationSummary, 
									loginURL string, outputFormat string, 
									printer Printer, k8sVersion string, policyName string) error {....}

In this function, we have nine arguments in total, and apparently they don’t have a logical order. We could try make sense of this arguments, but we can only guess by just looking at the argument. Following clean code conventions we want to group this arguments and/or separate the logic of this function. This is up for discussion 😊

Requirements
Golang basic level.

@noaabarki noaabarki added enhancement New feature or request up for grabs Looking for a contributor to take this task labels Feb 24, 2022
@github-actions github-actions bot added this to To Do in Datree Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request up for grabs Looking for a contributor to take this task
Projects
Datree
To Do
Development

No branches or pull requests

1 participant