From b7cd92e4fc0974e6381cd4c79ea271d732ae8e14 Mon Sep 17 00:00:00 2001 From: Jordan Date: Wed, 11 Apr 2018 18:05:23 +0200 Subject: [PATCH] add comments before publishing new version --- .../android/trustkit/config/DomainPinningPolicy.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/trustkit/src/main/java/com/datatheorem/android/trustkit/config/DomainPinningPolicy.java b/trustkit/src/main/java/com/datatheorem/android/trustkit/config/DomainPinningPolicy.java index e0dbea5..179126d 100644 --- a/trustkit/src/main/java/com/datatheorem/android/trustkit/config/DomainPinningPolicy.java +++ b/trustkit/src/main/java/com/datatheorem/android/trustkit/config/DomainPinningPolicy.java @@ -43,6 +43,8 @@ public final class DomainPinningPolicy { throws MalformedURLException { // Run some sanity checks on the configuration // Check if the hostname seems valid + // DomainValidator.getInstance(true) allows TrustKit to include localhost in the valid domains + // see https://github.com/datatheorem/TrustKit-Android/issues/25 DomainValidator domainValidator = DomainValidator.getInstance(true); if (!domainValidator.isValid(hostname)) { throw new ConfigurationException("Tried to pin an invalid domain: " + hostname);