Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] use old create table interface to support mult spark version #3330

Closed
Tracked by #1574
FANNG1 opened this issue May 10, 2024 · 0 comments
Closed
Tracked by #1574
Assignees
Labels
improvement Improvements on everything

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented May 10, 2024

What would you like to be improved?

create table with StructType schema could support both 3.3 and newer versions.

// 3.4
default Table createTable(
   Identifier ident,
   Column[] columns,
   Transform[] partitions,
   Map<String, String> properties) throws TableAlreadyExistsException, NoSuchNamespaceException {
 return createTable(ident, CatalogV2Util.v2ColumnsToStructType(columns), partitions, properties);
}


//3.3
Table createTable(
   Identifier ident,
   StructType schema,
   Transform[] partitions,
   Map<String, String> properties) throws TableAlreadyExistsException, NoSuchNamespaceException;

How should we improve?

No response

@FANNG1 FANNG1 added the improvement Improvements on everything label May 10, 2024
@FANNG1 FANNG1 self-assigned this May 11, 2024
@FANNG1 FANNG1 added 0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 and removed 0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 labels May 11, 2024
@FANNG1 FANNG1 closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on everything
Projects
None yet
1 participant