Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting loglevel through config file #217

Open
laurentS opened this issue Apr 19, 2022 · 2 comments
Open

Allow setting loglevel through config file #217

laurentS opened this issue Apr 19, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@laurentS
Copy link
Collaborator

While there is a logging_level setting in the config file, it does not seem to be taken into account by the code.

The only setting which seems to have an effect on the loggers is buried in the dependencies under .venv/lib/python3.9/site-packages/singer/logging.conf which has a level=INFO line which can be changed to adjust the log level. This is less than ideal :)

@laurentS laurentS added the bug Something isn't working label Apr 19, 2022
@laurentS
Copy link
Collaborator Author

It looks like the reason for this bug is that, while self.LOGGER.setLevel() is called correctly, its value is overwritten somewhere afterwards with INFO.

@laurentS
Copy link
Collaborator Author

laurentS commented Jun 1, 2022

Somebody found this problem a while ago it seems singer-io/singer-python#113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant