Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: adjust RPC error #491

Open
drmingdrmer opened this issue Aug 3, 2022 · 1 comment
Open

Draft: adjust RPC error #491

drmingdrmer opened this issue Aug 3, 2022 · 1 comment
Labels
draft Unfinished issue

Comments

@drmingdrmer
Copy link
Member

Do not read. unfinished draft.

ForwardToLeader depends on NodeData.
This caused all the depending types to include a new generic type Node.

The hierarchical structure of client_write() -> Result<ClientWriteResponse<C>, ClientWriteError<C::NodeId>> return value is as the following:

- OK: ClientWriteResponse
- Err: RpcError
  - NodeNotFound
  - Timeout
  - NetworkError
  - RemoteError
    - source: ClientWriteError
      - ForwardToLeader
      - ChangeMembershipError
      - Fatal
type ClientWriteResult = Result<ClientWriteResponse<C>, ClientWriteError<C::NodeId>>;
fn client_write() -> Result<ClientWriteResult, RpcError>;
- OK: 
  - Ok: ClientWriteResponse
  - Err: ClientWriteError
    - ChangeMembershipError
    - Fatal
- Err: RpcError
  - NodeNotFound
  - Timeout
  - NetworkError
  - ForwardToLeader
@drmingdrmer drmingdrmer added the draft Unfinished issue label Aug 3, 2022
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

👋 Thanks for opening this issue!

Get help or engage by:

  • /help : to print help messages.
  • /assignme : to assign this issue to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft Unfinished issue
Projects
None yet
Development

No branches or pull requests

1 participant