Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve robustness getWikiImage #3

Open
vict0rsch opened this issue Oct 2, 2018 · 2 comments
Open

Improve robustness getWikiImage #3

vict0rsch opened this issue Oct 2, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@vict0rsch
Copy link
Collaborator

For now, come images may not be found by the function even though they do appear on the wikipedia page

-> see src/utils/getWikiImage.js
@vict0rsch vict0rsch added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 2, 2018
@Asenar
Copy link

Asenar commented Oct 2, 2018

Example of image not found when it exists ?

@vict0rsch
Copy link
Collaborator Author

Le Journal De Haute-Marne
https://fr.wikipedia.org/wiki/Le_Journal_de_la_Haute-Marne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Asenar @vict0rsch