Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Extend primary key inference with dbt 'unique_key' config #893

Closed
adrianoesch opened this issue May 7, 2024 · 1 comment
Closed

Extend primary key inference with dbt 'unique_key' config #893

adrianoesch opened this issue May 7, 2024 · 1 comment
Labels
enhancement New feature or request triage

Comments

@adrianoesch
Copy link

adrianoesch commented May 7, 2024

Is your feature request related to a problem? Please describe.
The unique_key configuration in incremental models as recommended from dbt is ignored.

Describe the solution you'd like
Extend primary key inference with dbt's recommended unique_key configuration: https://docs.getdbt.com/docs/build/incremental-models#defining-a-unique-key-optional

Describe alternatives you've considered
Go through all models and adjust dbt config to data-diff requirements.

@adrianoesch adrianoesch added the enhancement New feature or request label May 7, 2024
@github-actions github-actions bot added the triage label May 7, 2024
@glebmezh
Copy link
Contributor

Hi @adrianoesch,

Thank you for trying out data-diff and for taking the time to open this issue. We made a hard decision to sunset the data-diff package and won't provide further development or support. Diffing functionality will continue to be available in Datafold Cloud. We have completely rewritten the diffing engine in the cloud over the past few months and have solved the fundamental issues with the original algorithm used in the data-diff package. Feel free to take it for a trial or contact us at support@datafold.com if you have any questions.

-Gleb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

2 participants