Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

In a particular case the percentage of difference score and also the row count is wrong #738

Closed
rahulchoudhary91 opened this issue Oct 12, 2023 · 1 comment
Labels
bug Something isn't working stale_immune Immunity to stale bot

Comments

@rahulchoudhary91
Copy link

OS:- Mac
Version:- Ventura 13.4.1

Table A has 12 rows(Redshift)
Table B has 10 rows(Postgres)

All 10 rows present in table B are present in Table A
Note:- Id of rows starts from 0 to 11 in Redshift, Whereas the primarykey Id is like 0 to 11 in Postgres as well but does not have row with id as 0 and 2

Response from data-diff is as
output is as

11 rows in table A
10 rows in table B
2 rows exclusive to table A (not present in B)
0 rows exclusive to table B (not present in A)
0 rows updated
9 rows unchanged
18.18% difference score

The points marked in bold above are not correct.

Actually there is
12 rows in table A
8 rows unchanged(Id of row no 0 and 2 have been changed to 10 and 11 respectively) along with other fields in those rows
difference score percentage should be 16.67

@rahulchoudhary91 rahulchoudhary91 added the bug Something isn't working label Oct 12, 2023
@dlawin dlawin added stale_immune Immunity to stale bot and removed triage labels Oct 12, 2023
@glebmezh
Copy link
Contributor

Hi @rahulchoudhary91,

I'm sorry for the delay in following up on this. Thank you for raising this issue and for looking into potential solutions!

We made a hard decision to sunset the data-diff package and won't provide further development or support.

If that's of interest, over the past few months, we have rewritten the diffing engine in Datafold Cloud and solved many issues that existed in this package's diffing algorithm. Feel free to take it for a trial and contact us at support@datafold.com if you have any questions.

-Gleb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working stale_immune Immunity to stale bot
Projects
None yet
Development

No branches or pull requests

3 participants