Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case Sensitivity Bug in Several Transforms #147

Open
yakshpatell opened this issue Jul 12, 2022 · 1 comment
Open

Case Sensitivity Bug in Several Transforms #147

yakshpatell opened this issue Jul 12, 2022 · 1 comment

Comments

@yakshpatell
Copy link

yakshpatell commented Jul 12, 2022

Hello,

I am seeing a very similar issue related to the previous issue I had opened for the merge transform: #145.

Would you mind adding support for case sensitivity for all the supported transforms I have listed below?

Here is a list of transforms that I have directly found the bug in.

  1. dataFrame.bake()
  2. dataFrame.renameSeries()
  3. dataFrame.where()

Here is a list of some other transforms that my codebase uses but haven't gotten the chance to test for the bug in there. I suspect some of these do contain the bug as well. If you could check these as well, that would awesome!

  1. getColumns
  2. getColumnNames()
  3. getSeries()
  4. withSeries()
  5. subset()
  6. dropSeries
  7. reorderSeries
  8. toArray
  9. toRows()
  10. count()
  11. forEach
  12. orderBy
  13. orderByDescending

Thanks,
Yaksh

@yakshpatell yakshpatell changed the title Case Sensitivity Bug in Many Transforms Case Sensitivity Bug in Several Transforms Jul 12, 2022
@ashleydavis
Copy link
Member

Hi @yakshpatell, sorry struggling to find the time.

You are welcome to fix these issues yourself and submit a PR. A PR per function updated would work best I think.

You can use issue 145 and my recent fix as a guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants