Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature:1221 - Make visibility of auto-approval toggle configurable based on confidentiality #1223

Merged
merged 2 commits into from May 1, 2024

Conversation

anushka-singh
Copy link
Contributor

Feature or Bugfix

  • Feature

Detail

  • Users should be able to disable visibility of auto-approval toggle with code. For example, at our company, we require that shares always go through approval process if their confidentiality classification is Secret. We dont even want to give the option to users to be able to set autoApproval enabled to ensure they dont do so by mistake and end up over sharing.

Video demo: #1221 (comment)

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx
Copy link
Contributor

dlpzx commented Apr 26, 2024

Hi @anushka-singh the frontend changes look good; but I guess we also want to disable that functionality from the backend. Especially when the users start using the CLI/SDK we will need to disable the feature in the server side

@dlpzx dlpzx self-requested a review April 26, 2024 09:42
Copy link
Contributor

@dlpzx dlpzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good. Agreed offline with @anushka-singh thata. follow-up backend PR is needed

@anushka-singh
Copy link
Contributor Author

We will tackle backend changes in a follow-up PR

@noah-paige
Copy link
Contributor

@anushka-singh please reference this PR in the one you open for backend - merging this one now

@noah-paige noah-paige merged commit 750a5ec into data-dot-all:main May 1, 2024
9 checks passed
@anushka-singh
Copy link
Contributor Author

@noah-paige
Yes I will do that!
Thanks for the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make visibility of auto-approval toggle configurable based on confidentiality
3 participants