Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DA admins to view share logs #1215

Closed
zsaltys opened this issue Apr 24, 2024 · 1 comment · Fixed by #1274
Closed

Allow DA admins to view share logs #1215

zsaltys opened this issue Apr 24, 2024 · 1 comment · Fixed by #1274
Assignees
@SofiaSazonova
Labels
effort: medium type: enhancement Feature enhacement
Projects
v2.6.0

Comments

@zsaltys
Copy link
Contributor

zsaltys commented Apr 24, 2024 •
edited

There can be many reasons why shares fail and we've had to many times log into infra account to view share manager logs. It would be really nice if DAAdministrators could have a button next to each share item which opens a modal with the CloudWatch logs when this share last ran. We have a similar modal for dataset and environment stacks.
@zsaltys zsaltys changed the title Allow to DA admins to view share logs Allow DA admins to view share logs Apr 24, 2024
@SofiaSazonova
Copy link
Contributor

To implement this we need

  1. Apply the same solution we have for the Stack Logs
  2. The tricky part: identify the log for the share task. Right now there is no way to identify the share by log-name. It's to be researched.

@SofiaSazonova SofiaSazonova added this to To do in v2.6.0 via automation May 14, 2024
@SofiaSazonova SofiaSazonova self-assigned this May 14, 2024
@SofiaSazonova SofiaSazonova moved this from To do to In progress in v2.6.0 May 15, 2024
@SofiaSazonova SofiaSazonova mentioned this issue May 15, 2024
Merged
@SofiaSazonova SofiaSazonova moved this from In progress to Review in progress in v2.6.0 May 15, 2024
@SofiaSazonova SofiaSazonova linked a pull request May 15, 2024 that will close this issue
Allow DA admins to view share logs #1274
Merged
SofiaSazonova added a commit that referenced this issue May 23, 2024
@SofiaSazonova
Allow DA admins to view share logs (#1274)
6c59e9d 
### Feature or Bugfix
<!-- please choose -->
- Feature

### Detail
- The latest logstream (last 24 hours) is loaded into modal window on
Share Object page
- User can see "Logs" button, if they are admins, stewards or owner of
the dataset


### Relates
- #1215 

### Security
Please answer the questions below briefly where applicable, or write
`N/A`. Based on
[OWASP 10](https://owasp.org/Top10/en/).

- Does this PR introduce or modify any input fields or queries - this
includes
fetching data from storage outside the application (e.g. a database, an
S3 bucket)?
  - Is the input sanitized?
- What precautions are you taking before deserializing the data you
consume?
  - Is injection prevented by parametrizing queries?
  - Have you ensured no `eval` or similar functions are used?
- Does this PR introduce any functionality or component that requires
authorization?
- How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  - Are you logging failed auth attempts?
- Are you using or adding any cryptographic features?
  - Do you use a standard proven implementations?
  - Are the used keys controlled by the customer? Where are they stored?
- Are you introducing any new policies/roles/users?
  - Have you used the least-privilege principle? How?


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Co-authored-by: Sofia Sazonova <sazonova@amazon.co.uk>
v2.6.0 automation moved this from Review in progress to Done May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SofiaSazonova SofiaSazonova

Labels
effort: medium type: enhancement Feature enhacement
Projects
v2.6.0
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow DA admins to view share logs SofiaSazonova/dataall
3 participants
@SofiaSazonova @zsaltys @noah-paige