Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

better behavior when one of the pipeline commands crashes #9

Open
max-mapper opened this issue Oct 21, 2014 · 1 comment
Open

better behavior when one of the pipeline commands crashes #9

max-mapper opened this issue Oct 21, 2014 · 1 comment

Comments

@max-mapper
Copy link
Contributor

right now if a command in the e.g. middle of the pipeline closes gasket doesn't produce any output

it would be nice if there was a debug mode that told you when all of the gasket pipeline commands end w/ their exit codes

@fgrehm
Copy link

fgrehm commented Dec 10, 2014

Not sure if I should create a separate issue for what I am facing but we are looking into using gasket extensively at the company I'm working for and while doing some spikes I noticed some "weird behavior" during crashes which I don't know if it is the intended Gasket's behavior or not.

To give you some background, we are planning to use gasket from a Jenkins job and one of the things we noticed on initial testing is that Gasket does not return an exit code != 0 when a pipeline crashes.

The simplest example I can put together is:

$ cat gasket.json
{ "test": [ "curl waaaat.com", "cat" ] }

$ gasket run test; echo $?
0

I even tried using gasket as a module but I got the same behavior:

$ cat foo.js
var gasket    = require('gasket');
var pipelines = gasket({ example: [ "curl waaaat.com", "cat" ] });

pipelines.run('example').pipe(process.stdout);
console.log('Things did not break :(');

$ node foo.js
Things did not break :(

Why the exit code is important for us? The data generated by our pipeline will end up being pushed into rabbitmq so that other process can kick in and continue some additional processing. If we can't detect automatically that the gasket side of things had an issue from the Jenkins job we will never know if things are working as expected.

Hopefully that's clear enough. Please LMK if you need any additional information! :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants