Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pipelines using Registry / via tuple #57

Open
pbrooko opened this issue Jun 30, 2021 · 2 comments
Open

Support for pipelines using Registry / via tuple #57

pbrooko opened this issue Jun 30, 2021 · 2 comments
Labels
contributions welcome Contributions welcome

Comments

@pbrooko
Copy link

pbrooko commented Jun 30, 2021

Hello!

I'm busy playing with Broadway for a use-case with many pipeline's that are created & destroyed dynamically. The changes introduced in dashbitco/broadway#239 seem perfect for this by allowing pipeline naming using a via tuple / Registry.

The broadway_kafka producer still assumes pipeline's are named using an atom, and tries to use Module.concat/2 to build it's own child process names.

Is there a sane way to get the Kafka producer to also support naming its children using the pipeline's process_name/2 function?

@josevalim
Copy link
Member

Yes, if we depend on master we should be able to rely on the process_name API for the same result. A PR would be welcome!

@pbrooko
Copy link
Author

pbrooko commented Jun 30, 2021

Awesome, will see what I can put together..

@josevalim josevalim added the contributions welcome Contributions welcome label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome Contributions welcome
Projects
None yet
Development

No branches or pull requests

2 participants