Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WASM, Windows] Mouse position incorrect with screen DPI 150% (UI interaction broken) #73

Open
nokola opened this issue Nov 18, 2023 · 5 comments
Labels
bug Something isn't working
Milestone

Comments

@nokola
Copy link
Contributor

nokola commented Nov 18, 2023

  1. Set monitor to 150% DPI in Windows 10
  2. Open https://comfyengine.org/examples/
  3. Click blood_canvas example
  4. Click letter "f"

Expected: blood under "f"
Actual: blood offset lower right
image

Note: this breaks UI interaction like button clicks as well due to mouse pos issues.

@darthdeus
Copy link
Owner

Does this only happen for you on the web, or also on desktop?

@darthdeus darthdeus added the bug Something isn't working label Nov 20, 2023
@nokola
Copy link
Contributor Author

nokola commented Nov 21, 2023

Web only

@nokola nokola changed the title Mouse position incorrect with screen DPI 150% (UI interaction broken) [WASM only] Mouse position incorrect with screen DPI 150% (UI interaction broken) Nov 21, 2023
@nokola nokola changed the title [WASM only] Mouse position incorrect with screen DPI 150% (UI interaction broken) [WASM, Windows] Mouse position incorrect with screen DPI 150% (UI interaction broken) Dec 4, 2023
@nokola
Copy link
Contributor Author

nokola commented Dec 4, 2023

I can see a high DPI issue on Windows now.

150% DPI offsets the egui window incorrectly. It's supposed to be centered below:
image

@darthdeus
Copy link
Owner

Windows bug should be fixed now, WASM isn't yet.

@darthdeus
Copy link
Owner

Seems this issue is fixed in WASM too but not on the website. I wonder if there's something wrong with the website that further stretches the canvas or something that causes this, but it doesn't seem to happen when running https://github.com/darthdeus/comfy/tree/master/demos/egui-scaling through wasm-server-runner

@darthdeus darthdeus added this to the v0.4.0 milestone Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants