Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid_redundant_argument_values not working for toList() #4967

Open
feinstein opened this issue May 9, 2024 · 1 comment
Open

avoid_redundant_argument_values not working for toList() #4967

feinstein opened this issue May 9, 2024 · 1 comment
Labels
false-negative P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@feinstein
Copy link

This code triggers a warning:

image

But this one doesn't:

image
@pq pq added false-negative P3 A lower priority bug or feature request labels May 9, 2024
@pq
Copy link
Member

pq commented May 9, 2024

Oh! I can reproduce. (For some reason, param.computeConstantValue() is returning null for growable.)

Thanks for the report!

@pq pq added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label May 9, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue May 10, 2024
@pq
toList false negative test for avoid_redundant_argument_values
4d681b6 
See: dart-lang/linter#4967


Change-Id: I7dd892b8149b5a8562aab9eeb4e1fda256639110
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365866
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false-negative P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pq @feinstein