Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macros] support for prefer_const_constructors_in_immutables #4966

Closed
Tracked by #4881
pq opened this issue May 8, 2024 · 1 comment
Closed
Tracked by #4881

[macros] support for prefer_const_constructors_in_immutables #4966

pq opened this issue May 8, 2024 · 1 comment
Assignees
@pq
Labels
false-positive P2 A bug or feature request we're likely to work on set-flutter Affects a rule in the recommended Flutter rule set

Comments

@pq
Copy link
Member

pq commented May 8, 2024 •
edited

Since constructors in macro definitions must be const and will produce a compilation error if not, this lint would be overreporting in the odd case where a macro is marked @immutable.
@pq pq mentioned this issue May 8, 2024
Open
@github-actions github-actions bot added the set-flutter Affects a rule in the recommended Flutter rule set label May 8, 2024
@pq pq self-assigned this May 8, 2024
@pq pq changed the title [macros] evaluate support for prefer_const_constructors_in_immutables [macros] support for prefer_const_constructors_in_immutables May 8, 2024
@pq pq added false-positive P2 A bug or feature request we're likely to work on labels May 8, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue May 10, 2024
@pq
don't report prefer_const_constructors_in_immutables on macro const…
a9905e9 
…ructors

Fixes: dart-lang/linter#4966

Change-Id: I4aee65dc62df509833796100ca6f86b904fc72ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365860
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
@pq
Copy link
Member Author

pq commented May 10, 2024

Fixed w/ dart-lang/sdk@a9905e9.

@pq pq closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
false-positive P2 A bug or feature request we're likely to work on set-flutter Affects a rule in the recommended Flutter rule set
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pq