-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: mention that an async function has no await keyword in the function body #4948
Comments
An I don't see a warning if an |
From my understanding, if there is no I see this to be deliberated when implementing an interface for example but I imagine the linter can detect if you overwrite something. I would be happy with false positives in my case. If I can remove a bunch of Remember that linters are optional and activated manually. |
From the outside, the signature is pretty much the function. So no difference except everything about how to use the function. It's possibly a reasonable lint while developing, if you notice that a function that you made async because it needed to be, now no longer needs to be async. It's useful during the design phase, or for private helper functions, but not for public API. |
@lrhn I agree with you. |
when you modify your code, you can remove the last
await
in a function so the function can become synchronous but nothing tells you that and you keepawait
something that doesn't need to.The text was updated successfully, but these errors were encountered: