Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid_void_async does not report on methods and local functions named 'main'. #4941

Open
srawlins opened this issue Apr 17, 2024 · 0 comments
Labels
false-negative P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@srawlins
Copy link
Member

The idea was to not report top-level functions named 'main'.

@srawlins srawlins added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P3 A lower priority bug or feature request false-negative labels Apr 17, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Apr 18, 2024
Fixes dart-lang/linter#3119

Fixes a rendering issue here with raw HTML:
https://dart.dev/tools/linter-rules/avoid_void_async

Documents dart-lang/linter#4941

Also deduplicates the implementation code.

Also, the test cases were not grouped very well. I grouped them,
removed a few duplicates, added some missed cases.

Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: I4a0b91c85bd8a359388a26d38b7f084ae9909f5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
false-negative P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

1 participant