Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad diff #82

Open
danvk opened this issue Jan 27, 2015 · 0 comments · May be fixed by #150
Open

Bad diff #82

danvk opened this issue Jan 27, 2015 · 0 comments · May be fixed by #150

Comments

@danvk
Copy link
Owner

danvk commented Jan 27, 2015

When I run webdiff https://github.com/danvk/webdiff/pull/81/files and look at webdiff/static/js/components.jsx, there are a few issues:

  1. The Root class (lines 5–90 on the right side) has a confusing diff. There are lots of identical before/after lines, but they're not rendered next to one another.
  2. Syntax highlighting seems to get confused by the jsx.
@danvk danvk linked a pull request Sep 17, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use git diff for diffs danvk/webdiff
1 participant
@danvk