Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden ownership of dygraphs #727

Open
danvk opened this issue Feb 8, 2016 · 14 comments
Open

Broaden ownership of dygraphs #727

danvk opened this issue Feb 8, 2016 · 14 comments

Comments

@danvk
Copy link
Owner

danvk commented Feb 8, 2016

dygraphs is a popular project, but lately it hasn't been getting the amount of work it deserves:

I don't expect to have much time to spend on dygraphs in the near future. @kberg isn't likely to, either. @pshevtsov has expressed interest in getting more involved. If you're a contributor who's interested in becoming a collaborator or owner, now would be a great time!

Recent contributors who might be interested: @timeu @kbaggott @reinert @mjanda @sslepian @cthrax

The next step for dygraphs is to get a 2.0.0 release out which incorporates the many improvements which have been made over the past year. If you're interested in helping out, please either respond on this issue or shoot me an email.

@timeu
Copy link
Collaborator

timeu commented Feb 8, 2016

I am also quite busy but I wouldn't mind helping out with the release (althogh I don't know the details of the process) and if there is time in between fixing bugs.

@danvk
Copy link
Owner Author

danvk commented Feb 8, 2016

I've added @pshevtsov and @timeu as collaborators. The more the merrier! There's a 2.0.0 milestone with a few easy bug fixes, and of course the giant backlog of 160 open issues. Please still send PRs for anything you'd like to fix.

@kbaggott
Copy link
Collaborator

kbaggott commented Feb 9, 2016

I'm not very experienced in writing tests but more than happy to help with issues and new features as and when I have time?

@danvk
Copy link
Owner Author

danvk commented Feb 10, 2016

@kbaggott I've added you, too. Help dealing with issues (especially closing out invalid issues and dupes) would be greatly appreciated.

@klausw
Copy link
Contributor

klausw commented Mar 1, 2016

I can't currently commit to any ongoing development work, though I do want to stay in the loop for areas related to code I've been working on. Unfortunately our internal repository has stopped tracking upstream due to alleged incompatibilities. I'll try to sort out what's going on there, but I may be stuck with backporting fixes on a case-by-case basis, and that's obviously not a good situation for making contributions.

@LostInBrittany
Copy link

If you still need people to help, please add me, I use Dygraph in some critical projects for my company and I really want to see it going forward...

@danvk
Copy link
Owner Author

danvk commented Sep 14, 2016

@LostInBrittany thanks for the kind offer. The best thing to do is send a PR to fix some issue on the 2.0.0 milestone (perhaps #669?). I'll review it and then we can get you added.

I would like to do a 2.0.0 release candidate soon. The only real remaining TODO is #678.

@danvk
Copy link
Owner Author

danvk commented Sep 15, 2016

@LostInBrittany or just a PR for your own issue :) #775

@LostInBrittany
Copy link

I'm digging on it... :)

On Thu, Sep 15, 2016 at 3:31 PM, Dan Vanderkam notifications@github.com
wrote:

@LostInBrittany https://github.com/LostInBrittany or just a PR for your
own issue :) #775 #775


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#727 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAsVzJd2Ko0PQdCL-wgqOiDDfHHeQuVoks5qqUjOgaJpZM4HVvmn
.

@reinert
Copy link
Contributor

reinert commented Sep 15, 2016

It's good to know who is working in what. So two people don't waste effort
on the same issue.

Em qui, 15 de set de 2016 às 10:37, Horacio Gonzalez <
notifications@github.com> escreveu:

I'm digging on it... :)

On Thu, Sep 15, 2016 at 3:31 PM, Dan Vanderkam notifications@github.com
wrote:

@LostInBrittany https://github.com/LostInBrittany or just a PR for
your
own issue :) #775 #775


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#727 (comment),
or mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AAsVzJd2Ko0PQdCL-wgqOiDDfHHeQuVoks5qqUjOgaJpZM4HVvmn

.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#727 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABOddpcTeYXGcO-X5GzCaREdY5qSMXx4ks5qqUocgaJpZM4HVvmn
.

Danilo Reinert

@danvk
Copy link
Owner Author

danvk commented Sep 15, 2016

@reinert sure! If anyone is working on an issue, they should leave a comment on it or assign it to themselves.

@LostInBrittany
Copy link

I'm trying to find a solution, but I'm rather new to the code of Dygraphs
(I've been using it for a year or two, but I have begun to look at its code
this week), so I don't considerer myself competent enough to assign the bug
to myself, as I'm not sure to be able to find the cause in a raisonnable
time span...

On Thu, Sep 15, 2016 at 7:30 PM, Dan Vanderkam notifications@github.com
wrote:

@reinert https://github.com/reinert sure! If anyone is working on an
issue, they should leave a comment on it or assign it to themselves.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#727 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAsVzO1Qh0bHudY4q2G2rHmIGXhqMfdKks5qqYC-gaJpZM4HVvmn
.

@mirabilos
Copy link
Collaborator

I did it.

I fixed bugs, converted this to Babel 7 (because that’s the version currently in Debian unstable), de-npm-ified the build process some (but it still works with npm, and I test this using GitHub Actions because Travis-CI doesn’t hand out new credits), created a Debian package and uploaded it (it’s currently pending ftpmaster review as it’s a NEW package).

I guess I could also push v2.1.1 to NPM to fix things like #1027 which users experience. I have no idea where the CDN takes its data from, though, so if there are any additional steps to take after npm publish (which would require you to add me first though), please enlighten me.

I’m very much not a JavaScript developer, and I especially do not know many of the new things in ES6, but I plan on using this for a project and keeping it alive and working in Debian. I don’t have enough skill to judge all the pull requests that there currently are, but I guess, if you’ll have me, a little palliative maintenance is better than none? It helps that I like to keep compatibility to older browsers alive (I have an experimental Leaflet application that works with Opera 9 except for the local File API which did not exist back then but is only an optional gimmick).

My strengths do lie with systems administration, (Korn) shell programming, Open Source stuff like licence analysis, packaging, etc. so co-maintainers that know a bit more about the web world are probably welcome. (I know my way around Python, even if I don’t personally like it.)

That is, again, if @danvk will have me.

https://github.com/mirabilos/dygraphs and I even put up a “live view” of that under https://dygraph.github.mirsolutions.de/ via GitHub Pages which fixes some of the annoying bugs like navigation not working, too. This is even included (fully workable!) in the Debian package.

@danvk
Copy link
Owner Author

danvk commented Dec 5, 2022

Hi @mirabilos -- if you've gotten all those changes working then I'd say you're definitely a JavaScript developer :) I'll follow up with you over email about dygraphs maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants