Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests on winodws are broken because of PHP_EOL #66

Open
c33s opened this issue Mar 8, 2019 · 0 comments
Open

Tests on winodws are broken because of PHP_EOL #66

c33s opened this issue Mar 8, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@c33s
Copy link
Contributor

c33s commented Mar 8, 2019 

3) DTL\Extension\Fink\Tests\Unit\Console\Display\ReportListDisplayTest::testRendersListOfReports
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'[200] https://www.example1.com\n
+'[200] https://www.example1.com\r\n
 [200] https://www.example2.com'

as all serious editors on windows are able to handle linux file endings, i suggest (as windows user) to not use PHP_EOL but hardcoded linux line endings or a setting/parameter where linux line endings are default.
@c33s c33s mentioned this issue Mar 8, 2019
Open
@dantleech dantleech added the bug Something isn't working label Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dantleech @c33s