Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cerberus templates #80

Open
danmindru opened this issue Apr 20, 2020 · 3 comments
Open

Add cerberus templates #80

danmindru opened this issue Apr 20, 2020 · 3 comments
Labels
beginner-friendly enhancement should-implement

Comments

@danmindru
Copy link
Owner

https://tedgoas.github.io/Cerberus/
@danmindru danmindru changed the title Add cerberus temlates Add cerberus templates May 7, 2021
@paskainos
Copy link

Potential conflict...?

CSS Inliners

  • Cerberus is supposed to be simple and should not require a dependency like a CSS inliner.
  • The placement of Cerberus’s CSS is already optimized. The CSS in the <head> is meant only for email clients that parse CSS in this location. It doesn’t need to be inlined.
  • There are some CSS selectors like :hover that don’t inline so well and cause errors in some CSS inliners.
  • Inlining leads to code bloat. Not only does this impact download speeds, but some email clients like Gmail and iOS Outlook truncate messages after they exceed a certain file size.

@danmindru
Copy link
Owner Author

@paskainos hmm yep, I guess we'd have to do without <head> for those templates.
I wonder how "responsive" they'd be in that case. Regardless, it'll still be good to have a few more templates available.

@paskainos
Copy link

@danmindru Agreed! We (and our clients) have benefited a great deal from your pioneering work. Please let me know if we can help with more templates. FWIW: Awhile back, we goofed around with mailchimp/email-blueprints. The integration was seamless, but using them proved (for us) clunky and prohibitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner-friendly enhancement should-implement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paskainos @danmindru