Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attandance on mobile app is having error with moodlecloud.com hosting. #700

Open
aliallawati opened this issue Sep 15, 2023 · 4 comments
Open
Labels

Comments

@aliallawati
Copy link

Hi,
i am moodlecloud.com user with Premium plan, i am trying to use "Attendance" Activity/Plugin to submit student attendance through moodle app,
when i select the appropriate class> attendance activity> select session (submit attendance button) , i get an error "template has some errors and can not be displayed"

Need your support to fix the issue, our teachers are depending on the app to record student attendance
Thank you.
Ali

select_session_in_app

err
@danmarsden
Copy link
Owner

Hi @aliallawati - thanks for the report, sounds like a recent change to the app or to the version of the attendance plugin installed on moodlecloud.com has an issue as this definitely used to work - pinging @jleyva FYI - I'm not sure I'll get time to look into this in the short term so any further help anyone can give to identify this issue would be useful.

thanks!

@danmarsden danmarsden added the bug label Sep 17, 2023
@jleyva
Copy link

jleyva commented Sep 25, 2023

@dpalou is this error caused by the server, particularly, the moustache template not properly rendering?

@dpalou
Copy link
Contributor

dpalou commented Sep 26, 2023

Hi @danmarsden , I was able to reproduce the error in a local site and it seems to be an error in the plugin's code.

The template returned by the plugin contains an empty (ionSelect), and Angular doesn't allow that so an error is thrown:

<ion-radio-group [(ngModel)]="CONTENT_OTHERDATA.statusall" (ionChange)="">

I debugged it a bit, and the list of users in this line is empty. This means that $data['selectall'] is an empty string, and it causes this error.

I don't know the attendance plugin's code and use cases enough to fix this myself. E.g. I don't know if the problem is that this line should always return users but now it isn't for some reason, or this is a real use case that isn't treated properly.

@danmarsden
Copy link
Owner

thanks heaps @dpalou - that's really useful - This is pretty high on my list of things to look at but of course it will need to be done in my "free time" which is not easy to find... :-) happy for anyone else to dig further and send a pull request though!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants