Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative links within HTML not resolved #275

Open
mimecuvalo opened this issue Feb 13, 2019 · 0 comments
Open

Relative links within HTML not resolved #275

mimecuvalo opened this issue Feb 13, 2019 · 0 comments

Comments

@mimecuvalo
Copy link

mimecuvalo commented Feb 13, 2019

FeedParser version: 2.2.9
Node version: 11.0.0
Link to feed exhibiting the issue: http://feeds.kottke.org/main

Search for any of the tags within the Kottke feed and you'll see they're all relative. The xml:base is specified on the tag containing it but it's not being applied to the HTML contained within.

I'm migrating my codebase from Python->JS so I'm used to Python's FeedParser handling this. I've hacked around it for now via a regex in my codebase but walking the XML structure/AST (however you're parsing it in your codebase) properly is the better solution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant