Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question]: Rewrite of generate-environment-identifiers-dict.sh? #998

Open
molangning opened this issue Apr 5, 2024 · 3 comments
Open

[Question]: Rewrite of generate-environment-identifiers-dict.sh? #998

molangning opened this issue Apr 5, 2024 · 3 comments
Labels
proposal Status: Proposal

Comments

@molangning
Copy link
Contributor

The script uses majestic 1 million.

However, domcorp’s list contains 10 million domains, which would allow us to generate a bigger list.

Additionally, would a python rewrite be appreciated?

@righettod
@molangning molangning added the proposal Status: Proposal label Apr 5, 2024
@righettod
Copy link
Contributor

Hi,

Nice idea and proposal 👍

Feel free to submit a PR with a refactoring of the script 😉

@molangning
Copy link
Contributor Author

Thank you for the feedback! I will do just that.

@righettod
Copy link
Contributor

Thank a lot 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal Status: Proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@righettod @molangning