Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the code to get the file size in _directory_model_from_path() commented out? #131

Open
aidy1991 opened this issue Nov 11, 2021 · 1 comment

Comments

@aidy1991
Copy link

https://github.com/danielfrg/s3contents/blob/main/s3contents/genericmanager.py#L179

Here, the code getting the file size is commented out. Is there a reason for this?
This line doesn't seem to affect the performance either, since it just retrieves the value from the already loaded s3_detail.

@danielfrg
Copy link
Owner

I dont remember, it could be a mistake. Only one way to find out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants