Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alacritty deprecated YAML format for TOML #210

Merged
merged 2 commits into from
May 18, 2024

Conversation

MadJlzz
Copy link
Contributor

@MadJlzz MadJlzz commented Apr 23, 2024

Fixes #204

@daltonmenezes
Copy link
Owner

Hi @MadJlzz , I'm sorry for the delay. Also, we never must change any file in the packages folder manually, we always should make changes in the src/ports folder, then you can rebuild the alacritty port by running:

yarn build only alacritty

please, read the docs to make it properly and also adding yourself as a contributor in the port readme

@MadJlzz
Copy link
Contributor Author

MadJlzz commented May 17, 2024

Sure thing @daltonmenezes ; I will check that today or this weekend

@MadJlzz
Copy link
Contributor Author

MadJlzz commented May 17, 2024

@daltonmenezes done! Should I rebase or is that okay for you?

@daltonmenezes daltonmenezes self-requested a review May 18, 2024 13:57
@daltonmenezes
Copy link
Owner

@daltonmenezes done! Should I rebase or is that okay for you?

It`s okay, thank you so much @MadJlzz 💜

@daltonmenezes daltonmenezes merged commit ddc0e48 into daltonmenezes:main May 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update alacritty package and related instructions to use TOML
2 participants