Cannot redock DockWidgets on Wayland

[yaminb]

Steps to reproduce:

1. Check View-FolderAsWorkspace
2. Undock the FolderAsWorkspace Window
3. You cannot redock it on the left pane as it original

[dail8859]

What OS and Notepad Next version are you using?

On Windows 10 and Notepad Next v0.6.3 it works fine for me.

[yaminb]

Ubuntu 23.10 0.6.3 (flathub)

…

On Wed, Sept 27, 2023, 7:24 a.m. dail8859 ***@***.***> wrote: What OS and Notepad Next version are you using? On Windows 10 and Notepad Next v0.6.3 it works fine for me. — Reply to this email directly, view it on GitHub <#451 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACX52MPBZ3MNNCOCPNP4DWTX4QEF3ANCNFSM6AAAAAA5IT3PM4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[dail8859]

Thanks for the info! I don't have access to any Linux platforms currently...hopefully someone else will be able to test this out.

[yaminb]

I downloaded qtcreator. Ill play around with it to see if i can figure it out. Might be a flag or somesthing.

…

On Wed, Sept 27, 2023, 7:38 a.m. dail8859 ***@***.***> wrote: Thanks for the info! I don't have access to any Linux platforms currently...hopefully someone else will be able to test this out. — Reply to this email directly, view it on GitHub <#451 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACX52MPIZXMETXUZSTGNRLDX4QF3JANCNFSM6AAAAAA5IT3PM4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[dail8859]

@yaminb Any help would be greatly appreciated! 😄

[yaminb]

Might be a qt issue actually. frescobaldi/frescobaldi#1273 Potentially fixed i. Qt 6.7.

…

On Wed, Sept 27, 2023, 7:48 a.m. dail8859 ***@***.***> wrote: @yaminb <https://github.com/yaminb> Any help would be greatly appreciated! 😄 — Reply to this email directly, view it on GitHub <#451 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACX52MKA32WF4RQGZEMPDNDX4QHBBANCNFSM6AAAAAA5IT3PM4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[dail8859]

That's unfortunate to hear it is a Qt bug, but at least there is a known reason now! Thanks for looking into that!

[yaminb]

Might be a silly question, but I'm using QT Creator. It came with QT 6.3.1.
Do you know how/where to download 6.7 or higher? I can try it and test it out to make sure that is fixed.
Surprisingly hard to find.

[dail8859]

According to https://wiki.qt.io/Qt_6.7_Release the first beta release isn't supposed to be available until December of this year and an official release is next March.

On Windows I use the Qt installer and v6.6 is in preview release still.

[yaminb]

It's been a while since I developed in QT. Not sure if you can assist, but I tried to make the DockWidget to not be moved into a window if we're in wayland. I can add another check for the version of QT... but something is not right here.
It does set the feature flags and everything, yet the dockable windows can still be made floating (removed from the dock and into a window) This shouldn't be linux/wayland specific. Any ideas? I've tried placing code at other locatoins, but it doesn't seem to behave how I want it to. Seems pretty straight forward, but not behaving as such.

void MainWindow::applyPlatformWorkArounds()
{
    /* Linux Wayland does not play nice with Dockable Windows.
     * It is supposed to be fixed in QT 6.7 (unreleased)
     * see https://github.com/dail8859/NotepadNext/issues/451
     *  called after MainWindow(NotepadNextApplication *app)- after     restoreSettings();
     *
     * Disable undocking for this platform
     */

    if( QGuiApplication::platformName().compare("wayland")==0 )
    {
        QList<QDockWidget *> dockWidgets = findChildren<QDockWidget *>();

        for( int i=0; i < dockWidgets.count(); i++ )
        {
            QDockWidget* dw = dockWidgets.at(i);
            dw->setFloating(false);
            dw->setFeatures(dw->features() & (~QDockWidget::DockWidgetFloatable));
            dw->setFloating(false);
        }
    }


}

[dail8859]

I simplified it down a bit to just the findChildren() call and the loop and tested it on Windows.

If the QDockWidget is drug out it will "snap" back to the original position, or it will be dropped on whatever valid area it was hovering over. My assumption is that Qt temporarily creates a floating window for the animation. Possibly another Qt bug related to the floating widgets? Maybe turn off QDockWidget::DockWidgetMovable so it cannot be clicked and dragged.

Here is what your suggested code changes look like on Windows for reference:

[yaminb]

Yeah, QT is just not playing nice with wayland. Probably just wait till 6.7 release of QT and see if that fixes all this.

[dail8859]

@yaminb Thanks so much for looking into this and attempting at a possible workaround! We'll wait for v6.7 and keep our fingers crossed 🤞