Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight important parts in the code #19

Open
vritant24 opened this issue Jun 25, 2017 · 1 comment
Open

Highlight important parts in the code #19

vritant24 opened this issue Jun 25, 2017 · 1 comment

Comments

@vritant24
Copy link

Would it be possible to highlight the parts in the code that are being focussed on in the section?
A few times there is a lot of code including styles around the one or two lines of code that is being talked about. For example, in Rendering with ternary -

{subtitle ? (
          <h2 style={styles.subtitle}>{subtitle}</h2>
        ) : (
          <h3 style={styles.empty}>No subtitle</h3>
        )}

this is the part that should attract the reader's focus, but it blends in with 50 other lines of code.

@dabbott
Copy link
Owner

dabbott commented Jun 25, 2017

This would be very helpful. It would go in the underlying project, react-native-web-player.

I can do this at some point, but in case somebody wants to take it, this is a good place to start: https://github.com/dabbott/react-native-web-player/blob/master/components/workspace/Workspace.js#L357. We would add something like a new selectedLines=[...] prop and a url param for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants