Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notepad++ dev build NPP_OPEN fails #93

Open
vinsworldcom opened this issue Feb 7, 2024 · 5 comments
Open

Notepad++ dev build NPP_OPEN fails #93

vinsworldcom opened this issue Feb 7, 2024 · 5 comments

Comments

@vinsworldcom
Copy link

I'm testing latest pre-release Notepad++ 64-bit dev builds and find an issue with this commit:

notepad-plus-plus/notepad-plus-plus@bb278b2

Using the latest 8.8 NppExec, the NPP_OPEN command does not seem to work for me anymore.

On the previous Notepad++ 64-bit commit, using the NPP_OPEN command functions as expected - the file is opened in a Scintilla buffer.

@d0vgan
Copy link
Owner

d0vgan commented Feb 7, 2024

Seems to be a mistake in Notepad++'s code for NPPM_RELOADFILE. Now it always return TRUE, whereas I was expecting it to return either TRUE on success or FALSE of failure.

According to "Notepad_plus_msgs.h", it should be either TRUE or FALSE:

#define NPPM_RELOADFILE (NPPMSG + 36)
	//BOOL NPPM_RELOADFILE(BOOL withAlert, TCHAR *filePathName2Reload)

@vinsworldcom
Copy link
Author

Thanks for the quick diagnostic!

Shall I open a bug with Notepad++ then?

Cheers.

@d0vgan
Copy link
Owner

d0vgan commented Feb 7, 2024

Yes, I think so.

@vinsworldcom
Copy link
Author

@vinsworldcom
Copy link
Author

See: notepad-plus-plus/notepad-plus-plus#14708

Fix is coming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants