Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra internalID being reserved without a function? #46

Open
Gitoffthelawn opened this issue Jul 29, 2021 · 4 comments
Open

Extra internalID being reserved without a function? #46

Gitoffthelawn opened this issue Jul 29, 2021 · 4 comments

Comments

@Gitoffthelawn
Copy link
Contributor

Thank you for the v0.7 release. Overall, it looks great.

I noticed that my keyboard shortcut for a NppExec macro no longer worked.

To get it to work, in Notepad++'s shortcuts.xml, I had to change:

<PluginCommand moduleName="NppExec.dll" internalID="22" Ctrl="yes" Alt="no" Shift="yes" Key="50" />

to:

<PluginCommand moduleName="NppExec.dll" internalID="23" Ctrl="yes" Alt="no" Shift="yes" Key="50" />

Simple enough. But note that in Notepad++'s Shortcut Mapper UI, there is now a blank line for NppExec after Help/About. Is this a little bug, or is it intentional? It's like NppExec is reserving an extra internalID that it is not using.

@d0vgan
Copy link
Owner

d0vgan commented Jul 29, 2021

Please find it explained here:
#42

@Gitoffthelawn
Copy link
Contributor Author

Thanks so much. Your explanation in #42 makes perfect sense. The only curiosity is the blank item in Notepad++'s Shortcut Mapper for NppExec. Do you happen to know what is causing that?

@d0vgan
Copy link
Owner

d0vgan commented Jul 29, 2021

I hardly recalled that the blank item in Notepad++'s Shortcut Mapper for NppExec has a special purpose.
NppExec's Advanced Options has a check-box "Place to the Macros submenu". When it is checked, the NppExec's script menu items are moved from NppExec submenu to Notepad++'s Macro submenu. These script menu items include at least one menu item separator - right before the first script menu item. There can be more menu item separators added via NppExec's Advanced Options. And to be able to move them (these menu item separators) from NppExec submenu to Notepad++'s Macro submenu, they need to have menu item id that, in its turn, leads to an empty item in Notepad++'s Shortcut Mapper for NppExec.
NppExec_script_menu_items_under_Macro
NppExec_Shortcut_mapper

@Gitoffthelawn
Copy link
Contributor Author

Ah! You figured it out. Great job.

Would it make sense to add something like "Separator" or "Separator (do not use)" as a name string for those items? No big deal either way now that I understand what's going on, but other people might appreciate it (and I might forget!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants