Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add URCP-100-2H beads back #336

Open
deemishra opened this issue Apr 25, 2022 · 3 comments
Open

Feature Request: Add URCP-100-2H beads back #336

deemishra opened this issue Apr 25, 2022 · 3 comments

Comments

@deemishra
Copy link

Thank you for your bug report!

Please fill out the following template.

PLATFORM (Mac, PC, Linux, other): Mac

OPERATING SYSTEM (eg OSX 10.7, Windows 8.1): OSX Monterey 12.3.1

SEVERITY (Critical? Major? Minor? Enhancement?): Enhancement

DESCRIPTION:

URCP-100-2H beads used to be part of Cytoflow but removed in latest release. Please bring them back!
Spherotech no longer has it hosted on their website but I contacted support and they provided the xlsx file.
We're in the midst of running the bead code and updating our own instances but would be nice to have in the main release. I suppose I could do a pull request but won't get to it until the semester ends...

Don't forget to attach the log file to this bug report!

*If you are having trouble with a particular FCS file, please attach that file too.
Copy of Symphony LINEARITY PROGRAM - URCP-100-2H PMT QC TEMPLATE Rev A - 112520 Lock.xlsx

@bpteague
Copy link
Collaborator

Adding new beads is easy! I encourage you (or a student) to do so and submit a pull request:

  • Add the data to cytoflow/operations/beads.csv
  • Run cytoflow/scripts/parse_beads.py to parse them into a Python dict-of-dicts
  • Copy and paste the result into the appropriate place in cytoflow/operations/bead_calibration.py

@bpteague
Copy link
Collaborator

(I won't get to it until the semester ends either! And also it's nice to feel like I'm not the only contributor (; )

@akshayMpatel
Copy link

akshayMpatel commented Jun 21, 2022

@bpteague I've added the beads to my branch of the repo and made a pull request for merging. In the mean time...

  • Is there a way to run the GUI from my code base with the added beads?
  • Do you have an example of a beads file, so that we could make one for the desired beads and just input into the GUI version?

Many thanks!
Akshay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants