[3.0.x] Fix type of str call #6171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the type of a call to `str` has already been deduced as unicode (because of language_level=3), then keep that type. This was causing optimizations to fail, where the optimization was made on the basis that the type was unicode and then that was reversed by the replacement of `str`. Fixes cython#6166. Most of this doesn't need to go into 3.1.
scoder
reviewed
Apr 29, 2024
Cython/Compiler/Optimize.py
Outdated
| if node.type is Builtin.unicode_type: | ||
| node_type = ExprNodes.UnicodeNode | ||
| else: | ||
| node_type = ExprNodes.BytesNode |
There was a problem hiding this comment.
Shouldn't this still be StringNode in 3.0.x?
There was a problem hiding this comment.
Yes it should... Just spotted that myself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the type of a call to
strhas already been deduced as unicode (because of language_level=3), then keep that type.This was causing optimizations to fail, where the optimization was made on the basis that the type was unicode and then that was reversed by the replacement of
str.Fixes #6166.
Most of this doesn't need to go into 3.1.