New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring Config and JobConfig #728

Open

pulasthi opened this issue Nov 8, 2019 · 1 comment

Contributor

pulasthi commented Nov 8, 2019

Currently the users see both the Config and JobConfig objects, which can be confusing.

JobConfig: This can be renamed to JobParameters. It can hold job specific parameters supplied by the user. It will we part of Job object. It will be provided to each Worker with IWorker interface.
Config: This will have parameters that are specific to Twister2 system. Users should neither see this Config object when they submit the job, nor in IWorker.

A possible solution would be to hide Config from users. When they submit the job, they don't see Config

Collaborator

chathurawidanage commented Dec 5, 2019

edu.iu.dsc.tws.rsched.job.Twister2Submitter#submitJob(edu.iu.dsc.tws.api.Twister2Job) added from 0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment