Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestProducer duplication #532

Open
opotowsky opened this issue Feb 10, 2022 · 0 comments
Open

TestProducer duplication #532

opotowsky opened this issue Feb 10, 2022 · 0 comments

Comments

@opotowsky
Copy link
Member

@gonuke suggested moving some of the duplicate definitions between src/deploy_inst_test.h and src/manager_inst_tests.h into a separate header that could be read in by both, but that was not possible without creating a dummy prototype within cycamore that was blank. So the duplications remain, until a better solution is found.

Also, with the use of TestProducer by both src/deploy_insts_tests.cc and src/manager_insts_tests/cc, it seems that all of the information from the unit tests are stored while the tests are being run so this is not a major issue for now, since all of the unit tests and regression tests are running and passing. We should revisit this in the future though.

Originally posted by @abachma2 in #529 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants