Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header files for tests are included in cycamore.h #531

Open
gonuke opened this issue Jan 28, 2022 · 1 comment
Open

Header files for tests are included in cycamore.h #531

gonuke opened this issue Jan 28, 2022 · 1 comment

Comments

@gonuke
Copy link
Member

gonuke commented Jan 28, 2022

It seems undesirable to include the test header files for many archetypes in the general cycamore.h header, especially for building production versions for use without tests...

No proposal, just a request for investigation/clarification....
@abachma2
Copy link
Member

As a small bit of investigation I removed the test header files from src/cycamore.h. It was able to build fine, and all unit and regression tests passed. It at least appears that they are not needed in that file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gonuke @abachma2