Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale input files in tests directory #530

Open
opotowsky opened this issue Jan 26, 2022 · 1 comment
Open

Stale input files in tests directory #530

opotowsky opened this issue Jan 26, 2022 · 1 comment

Comments

@opotowsky
Copy link
Member

cycamore/tests/input seems to contain some input files that are not used in testing. Instead, cycamore/input is the file path for the input files that are tested. Thanks to @abachma2 for figuring this out! Happy to PR this deletion but wanted to get feedback first (i.e., are the input files in tests/input used for something else?)

@abachma2
Copy link
Member

abachma2 commented Jan 27, 2022

After looking at tests/test_regression.py it looks like files from inputs/ and tests/inputs/ are being used in the testing suite. I think instead of removing the tests/input/ directory we should figure out why there are input files in two locations. Are the files in inputs/ used for things other than regression testing?

The tests/run_inputs.py looks for input files in the inputs/ directory, not tests/input. Is there a reason this happens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants