Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Groupping (VPC/Subnets/Region) #6

Open
xescugc opened this issue Jul 15, 2020 · 1 comment · May be fixed by #37
Open

AWS Groupping (VPC/Subnets/Region) #6

xescugc opened this issue Jul 15, 2020 · 1 comment · May be fixed by #37
Assignees
@xescugc
Projects
InfraMap

Comments

@xescugc
Copy link
Member

xescugc commented Jul 15, 2020 •
edited

Add the logic for VPCs, Subnets and Regions. The idea is to have a Grouping between resources that belong to the same VPC, Subnet and/or Region.

On AWS reading the TFState/HCL we are able to know if some resource belong to those:

  • VPC: vpc_id and vpc_security_group_ids.
  • Subnets: TBD
  • Region: TBD

The idea would be to add a Groups on the provider.Provider that does the same as ResourceInOut that returns which groups the resource belongs to and then from that extend to different Providers bit by bit.
@xescugc xescugc self-assigned this Jul 15, 2020
@tormath1 tormath1 mentioned this issue Jul 16, 2020
Merged
@xescugc xescugc changed the title Groupping (VPC/Subnets) Groupping (VPC/Subnets/Region) Jul 17, 2020
@xescugc xescugc changed the title Groupping (VPC/Subnets/Region) AWS Groupping (VPC/Subnets/Region) Jul 17, 2020
@xlr-8
Copy link

xlr-8 commented Jul 21, 2020

Regarding the grouping mechanism, there are several more:

  1. Region
  2. VPC
  3. Security group (when there are more than 1 instance for example)
  4. Subnets
  5. Availability Zone (nice addition to the region one)

I'm not sure of the order of priority though, region/VPC seem fairly straight forward and good to start with.
Perhaps security groups & subnets afterwards, while leaving the AZ for the last.

@xescugc xescugc linked a pull request Aug 7, 2020 that will close this issue
Draft
@xescugc xescugc mentioned this issue Aug 24, 2020
Open
@xescugc xescugc added this to To do in InfraMap Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xescugc xescugc

Labels
None yet
Projects
InfraMap
To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added: Grouping for VPCs on AWS cycloidio/inframap
2 participants
@xescugc @xlr-8