Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsxFactory should be export from this package, not from @cycle/react-dom #8

Open
ryota-ka opened this issue May 4, 2020 · 3 comments · May be fixed by #9
Open

jsxFactory should be export from this package, not from @cycle/react-dom #8

ryota-ka opened this issue May 4, 2020 · 3 comments · May be fixed by #9

Comments

@ryota-ka
Copy link

ryota-ka commented May 4, 2020

Problem

jsxFactory should be export from @cycle/react, not from @cycle/react-dom.

Why

There are many DOM-free React projects in the world such as Ink and Adapt.

Library versions

package version
@cycle/react v2.7.0
@cycle/react-dom v2.4.0
@staltz
Copy link
Member

staltz commented May 4, 2020

Hmm, good point! PRs welcomed (hopefully 2 PRs, one to remove JSX pragma from @cycle/react-dom, another to add it here in @cycle/react)

@ryota-ka
Copy link
Author

ryota-ka commented May 5, 2020

Okay, I'll submit a pull request in a few days! (Luckily, now it's on holidays in Japan 😊)

BTW, instead of removing it from @cycle/react-dom at once, what do you think of deprecating it and remove it in the next major version bump?

@staltz
Copy link
Member

staltz commented May 6, 2020

BTW, instead of removing it from @cycle/react-dom at once, what do you think of deprecating it and remove it in the next major version bump?

Even better idea!

ryota-ka added a commit to ryota-ka/react that referenced this issue May 7, 2020
@ryota-ka
Support JSX Factory
f7be660 
Fixes cyclejs#8

Implementation of `jsxFactory` is just a copy and paste from @sliptype's
pull request (cyclejs/react-dom#3).
Test cases have been rewritten in a DOM-free way (using enzyme).
@ryota-ka ryota-ka linked a pull request May 7, 2020 that will close this issue
Open
ryota-ka added a commit to ryota-ka/react that referenced this issue May 7, 2020
@ryota-ka
Support JSX Factory
036bbfe 
Fixes cyclejs#8

Implementation of `jsxFactory` is just a copy and paste from @sliptype's
pull request (cyclejs/react-dom#3).
Test cases have been rewritten in a DOM-free way (using enzyme).
ryota-ka added a commit to ryota-ka/react that referenced this issue May 7, 2020
@ryota-ka
Support JSX Factory
6c65a15 
Fixes cyclejs#8

Implementation of `jsxFactory` is just a copy and paste from @sliptype's
pull request (cyclejs/react-dom#3).
Test cases have been rewritten in a DOM-free way (using enzyme).
ryota-ka added a commit to ryota-ka/react that referenced this issue May 7, 2020
@ryota-ka
Support JSX as a pragma
853e575 
Fixes cyclejs#8

Implementation of `jsxFactory` is just a copy and paste from @sliptype's
pull request (cyclejs/react-dom#3).
Test cases have been rewritten in a DOM-free way (using enzyme).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support JSX as a pragma ryota-ka/react
2 participants
@staltz @ryota-ka