Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outdated docs #16

Open
tobiaseisenschenk opened this issue Jun 26, 2019 · 3 comments
Open

outdated docs #16

tobiaseisenschenk opened this issue Jun 26, 2019 · 3 comments

Comments

@tobiaseisenschenk
Copy link

I love the concept behind cyclejs, but it seems like the docs are out of date as the example is not working with the current RN deps. Also there seems to be few work done on the react-native driver overall.
Do you think this project will get more attention in the future?

@staltz
Copy link
Member

staltz commented Jun 27, 2019

Could you tell me what are the errors that occur when you run the example with latest RN version?

@tobiaseisenschenk
Copy link
Author

yes, of course:

ExceptionsManager.js:74 NavigatorIOS is deprecated and has been removed from this package. Learn about alternative navigation solutions at http://facebook.github.io/react-native/docs/navigation.html
  | handleException | @ | ExceptionsManager.js:74
-- | -- | -- | --
  | handleError | @ | setUpErrorHandling.js:23
  | reportFatalError | @ | error-guard.js:42
  | guardedLoadModule | @ | require.js:199
  | metroRequire | @ | require.js:125
  | (anonymous) | @ | incorporate.js:91
  | executeApplicationScript | @ | debuggerWorker.js:40
  | (anonymous) | @ | debuggerWorker.js:72

The project runs on these versions:

  • "@cycle/react-native": "^1.4.0",
  • "@cycle/run": "^5.2.0",
  • "react": "16.8.3",
  • "react-native": "0.59.9",

Does the driver maybe depend on NavigatorIOS?

@staltz
Copy link
Member

staltz commented Jun 28, 2019

That's nice to know! This driver depends on NavigatorIOS, but very lightly (we just provide a shortcut for all their APIs). This should be very easy to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants