Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types are being omited #22

Open
happylolonly opened this issue Nov 22, 2023 · 1 comment
Open

Types are being omited #22

happylolonly opened this issue Nov 22, 2023 · 1 comment
Assignees
@cyborgshead
Labels
invalid This doesn't seem right

Comments

@happylolonly
Copy link
Member

This line omits TS types https://github.com/cybercongress/soft3.js/blob/main/src/cyberclient.ts#L401,
that produces difficulties with code understanding for front-end.

Possible to use extension modules from here https://github.com/cybercongress/soft3.js/blob/main/src/queries/rank.ts#L51 ?
Its keeping types ok.

image
@happylolonly happylolonly added the invalid This doesn't seem right label Nov 22, 2023
@happylolonly
Copy link
Member Author

Example of bad frontend code in core module, when types are unclear.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyborgshead cyborgshead

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cyborgshead @happylolonly