Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curve events are an utter mess #177

Open
kaber2 opened this issue May 12, 2023 · 1 comment
Open

Curve events are an utter mess #177

kaber2 opened this issue May 12, 2023 · 1 comment

Comments

@kaber2
Copy link

kaber2 commented May 12, 2023

Curve events are just a horrible mess without:

  • Some of the liquidity events return fixed sized arrays, meaning there is a different signature for each amount of tokens
  • RemoveLiquidityOne is missing the vital information, which coin was actually removed

So the first one, though butt-ugly, can be handled by just subscribing to all possible pool sizes. The second one can be handled as well, but even more uglier, since it requires any consumer that wishes to keep track of balances, to calculate the amount for all possible tokens to determine which one an event referred to. This of course requires to know the internal parameters of the pool, and:

  • There no pair creation or other initial event containing pool creation parameters

Sigh

Seriously, who "designed" such a mess? Given that basically every pool is incompatible in some way with the next one, to the extent that not even the pool registry is able to query a good proportion of them without reverting, how about just fixing this crap? Its not like ABI compatibility is an issue here...

@Hg347
Copy link

Hg347 commented Apr 7, 2024

Your criticism is written quite unkindly. In particular, there is no constructive suggestion as to what you think it should be like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants