Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show comments in Edit mode #37

Open
boonebgorges opened this issue Oct 25, 2015 · 4 comments
Open

Show comments in Edit mode #37

boonebgorges opened this issue Oct 25, 2015 · 4 comments

Comments

@boonebgorges
Copy link
Member

There was a conscious choice not to show comments in Edit mode, I think because we (I) thought it would be too complicated to show them both at once. It turns out that it probably isn't all that complicated, so maybe we should do it. I'm not sure who built this particular piece - was it you @r-a-y ?

If there are any technical hurdles then we definitely should not do this for v1.

@mkgold
Copy link
Member

mkgold commented Oct 25, 2015

It might be worth thinking about a show/hide comments toggle in edit mode. I'd hate to lose the clean writing interface but Erin is right that some people may want to see comments as they are writing.

@r-a-y
Copy link
Member

r-a-y commented Oct 25, 2015

I think because we (I) thought it would be too complicated to show them both at once. It turns out that it probably isn't all that complicated, so maybe we should do it. I'm not sure who built this particular piece - was it you @r-a-y ?

This is tied to the comment auto-repositioning issue. At the moment, we do not show comments because repositioning comments requires a page refresh.

@boonebgorges
Copy link
Member Author

Ah right. This should definitely be tabled then.

On 10/25/2015 11:50 AM, r-a-y wrote:

I think because we (I) thought it would be too complicated to show
them both at once. It turns out that it probably isn't all that
complicated, so maybe we should do it. I'm not sure who built this
particular piece - was it you @r-a-y <https://github.com/r-a-y> ?

This is tied to the comment auto-repositioning issue. At the moment, we
do not show comments because repositioning comments requires a page refresh.


Reply to this email directly or view it on GitHub
#37 (comment).

@sheesh
Copy link
Contributor

sheesh commented Oct 25, 2015

Agreed that it should be tabled for now if complicated. Thanks for the
thoughts.

erin rose glass | digital fellow | cuny grad center | nyc
www.erinroseglass.com | @erinroseglass

On Sun, Oct 25, 2015 at 1:03 PM, Boone Gorges notifications@github.com
wrote:

Ah right. This should definitely be tabled then.

On 10/25/2015 11:50 AM, r-a-y wrote:

I think because we (I) thought it would be too complicated to show
them both at once. It turns out that it probably isn't all that
complicated, so maybe we should do it. I'm not sure who built this
particular piece - was it you @r-a-y https://github.com/r-a-y ?

This is tied to the comment auto-repositioning issue. At the moment, we
do not show comments because repositioning comments requires a page
refresh.


Reply to this email directly or view it on GitHub
<
#37 (comment)
.


Reply to this email directly or view it on GitHub
#37 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants