Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned media insert not working properly #30

Open
boonebgorges opened this issue Oct 25, 2015 · 4 comments
Open

Aligned media insert not working properly #30

boonebgorges opened this issue Oct 25, 2015 · 4 comments

Comments

@boonebgorges
Copy link
Member

From http://commons.gc.cuny.edu/groups/cac-community-team-project-planning/docs/social-paper-beta-2-directory-page-and-writing-papers/#comment-2030:

The add media did not work for me when I chose to align left or right with a large image. Just got a blank box with a caption. When I set align center it worked.

There seem to be a non-trivial number of issues with media. Should we just disable it for v1?

@mkgold
Copy link
Member

mkgold commented Oct 25, 2015

Should we just disable it for v1?

If needed. I would like to see more testing on this, however, before we take that step, as it would be a significant feature loss.

@r-a-y
Copy link
Member

r-a-y commented Oct 25, 2015

We could also remove or hide the align buttons if they are causing issues for the media toolbar.

@sheesh
Copy link
Contributor

sheesh commented Oct 26, 2015

I agree with Matt that it would be a significant feature loss; I found the
easy ability to align the image very impressive and useful and did not
experience any issues.

I tried to replicate this bug by uploading an extremely large image. The
result was an error message. I think most users will know not to upload
large images.

erin rose glass | digital fellow | cuny grad center | nyc
www.erinroseglass.com | @erinroseglass

On Sun, Oct 25, 2015 at 5:46 PM, r-a-y notifications@github.com wrote:

We could also remove or hide the align buttons if they are causing issues
for the media toolbar.


Reply to this email directly or view it on GitHub
#30 (comment)
.

@christianwach
Copy link
Collaborator

I couldn't replicate this locally. Nor could I replicate on cdev when I created a new paper there. Anyone have an example of the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants