Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

willBeRetried not part of TestStepResult #1703

Closed
christian-bromann opened this issue Aug 20, 2021 · 7 comments
Closed

willBeRetried not part of TestStepResult #1703

christian-bromann opened this issue Aug 20, 2021 · 7 comments

Comments

@christian-bromann
Copy link

Describe the bug
The latest version of @cucumber/messages seems to mismatch with the current master branch. The willBeRetried property is in master part of the TestStepResult class, e.g.:

export class TestStepResult {

  @Type(() => Duration)
  duration: Duration = new Duration()

  message?: string

  status: TestStepResultStatus = TestStepResultStatus.UNKNOWN

  willBeRetried: boolean = false
}

However if you download latest package version it is part of TestCaseFinished for some reason:

export class TestCaseFinished {

  testCaseStartedId: string = ''

  @Type(() => Timestamp)
  timestamp: Timestamp = new Timestamp()

  willBeRetried: boolean = false
}

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
willBeRetried should be part of TestStepResult.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@mpkorstanje mpkorstanje transferred this issue from cucumber/messages-javascript Aug 20, 2021
@luke-hill
Copy link
Contributor

https://github.com/cucumber/common/blob/main/messages/CHANGELOG.md#1700---2021-07-08

It was moved as part of the latest breaking changes.

@mpkorstanje
Copy link
Contributor

@luke-hill this was orginally posted in cucumber/messages-javascript.

The last sync to the subrepo was on May 20th. So I think there is another underlying cause.

@mattwynne With #1550 in mind I think some sign posts need to be updated.

@luke-hill
Copy link
Contributor

Ah oki, rsync playing up then.

@mpkorstanje
Copy link
Contributor

Mmh. The master branch is out of date. The main branch is up to date.

@mattwynne same problem but because of #1561 instead.

@luke-hill
Copy link
Contributor

Actually I think it's the branch name. main seems correct: https://github.com/cucumber/messages-javascript/blob/main/src/messages.ts#L618

@aslakhellesoy
Copy link
Contributor

I've updated the default branch of https://github.com/cucumber/messages-javascript to be main. Does that fix this issue @christian-bromann ?

christian-bromann added a commit to webdriverio/webdriverio that referenced this issue Nov 2, 2021
@christian-bromann
Copy link
Author

@aslakhellesoy I updated the package, all looks good now, thank you team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants